Skip to content

Add autocompletion for team names and URLs #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2025
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 30, 2025

This should make it simpler to lookup this metadata.

Users will still probably override the team name to get a nicer string in the "on behalf of X" header. We could in theory also add the team type (working group, project group, team, etc.) to help us automatically generate that header string.

@Kobzol Kobzol requested a review from senekor April 30, 2025 10:23
@Kobzol Kobzol force-pushed the team-hint branch 3 times, most recently from a141935 to 449f873 Compare April 30, 2025 10:28
Copy link
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged as is.

What's the purpose of prompting for the URL when we were able to determine it? Is there a use case where authors might want to use a non-standard URL for an existing team?

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 30, 2025

Hmm, I'm not sure. There are definitely some old posts that have a custom URL, but I consider them to be mostly legacy. I guess that I just wanted to still give users a choice :) Let me know if you want me to automatically select the URL if the team name is known.

@senekor
Copy link
Contributor

senekor commented Apr 30, 2025

I'm leaning toward skipping the prompt, users can still change the front matter manually if they absolutely want to.

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 30, 2025

Ok, changed it. Also fixed a bug where for some teams the URL was not determined correctly.

Some teams have a custom URL on the website.
@Kobzol Kobzol merged commit 27bf750 into rust-lang:master May 1, 2025
5 checks passed
@Kobzol Kobzol deleted the team-hint branch May 1, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants