Core membership update post #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Sep 27, 2021
skade
previously approved these changes
Sep 27, 2021
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
pietroalbini
approved these changes
Sep 27, 2021
therealprof
reviewed
Sep 27, 2021
Comment on lines
+73
to
+74
| Rust Language Server. Their most recent work is with Nushell, a programming | ||
| language implemented in Rust. |
There was a problem hiding this comment.
A "programming language implemented in Rust"? That sounds potentially confusing to the reader and inaccurate to me. Officially it calls itself "A new type of shell."
There was a problem hiding this comment.
@therealprof - Nushell is both a shell and a language. Happy to chat more, though probably best to chat details on the Nushell repo/discord server.
There was a problem hiding this comment.
@jntrnr I'm aware (as a contributor), although I wouldn't quite see it as a programming language really, same as I wouldn't see SQL as a programming language. For the occasional reader this might read weird but if you're happy with that representation, that's certainly fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @rust-lang/core