Don't return Ok if update handler isn't run
#2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
pietroalbini
requested changes
Feb 20, 2020
0e3ac0b to
481a113
Compare
We're losing jobs to publish crates. It's not clear why. The requests are returning 200, which implies they are being queued correctly. There is no log to indicate that these jobs failed, so right now I believe that this job is erroneously returning `Ok` when it failed. Given GitHub is having a partial outage, that seems to reinforce this theory. From looking at the code, this looks like the only way we could have returned `Ok` when the publish failed. I believe we got some sort of error response (or lack of one) from GitHub that caused this callback not to be run.
pietroalbini
approved these changes
Feb 20, 2020
|
@bors r+ |
|
📌 Commit 09814cc has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're losing jobs to publish crates. It's not clear why. The requests
are returning 200, which implies they are being queued correctly. There
is no log to indicate that these jobs failed, so right now I believe
that this job is erroneously returning
Okwhen it failed. Given GitHubis having a partial outage, that seems to reinforce this theory.
From looking at the code, this looks like the only way we could have
returned
Okwhen the publish failed. I believe we got some sort oferror response (or lack of one) from GitHub that caused this callback
not to be run.