Fix reverse dependencies page that didn't work after ember upgrade #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a new test helper that matches a regex instead of text exactly because timezones :(
The base url behavior changed in the ember upgrade. Fixes rust-lang#553.
1f48376 to
5f31869
Compare
|
Nice! |
|
Nice I broke production but then i fixed it? LOL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently some behavior around
baseURL/rootURLchanged with the ember upgrade, and the reverse dependencies adapter constructs a custom URL that started being relative when it should be absolute.I also added a bunch more acceptance tests, which meant a bunch more mirage fixtures, to help us feel more confident about ember upgrades not breaking things in the future :)
I merged and deployed the ember upgrade (PR #501) last night, then I reverted the deploy but not the code today when I saw #553. So no git gymnastics needed, just a merge and then a deploy :)