Skip to content

adding credential fill to the executed commands in the CredentialHelper #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

adding credential fill to the executed commands in the CredentialHelper #1006

wants to merge 3 commits into from
+10 −4

Conversation

Black616Angel
Copy link

This PR adds the functionality of the "git credential fill" command to the git credential helper.
This allows for better retrieval of credentials.

The PR is in 3 commits:

  • repositioning a trailing "get" that got added to all commands, when it shouldn't have
  • adding the aforementioned command in the function "config_helper" (this position is definitely debatable)
  • checking if the returned username is empty, since "git credential fill" seems to always return something

@Black616Angel Black616Angel mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Black616Angel