Thanks for the PR! I don't think this is something we can land right away, because I believe there are books that are using the FA icons, and this would break them. I'll try to review it when I get a chance, but merging may need to wait until the next major release.

That’s fine. mdBook is still 0.4, so it can still release a 0.5 some time.

Also, I should probably document the fa handlebars helper in the manual. Since this is how it’s going to be done now. Should we also add some sort of Markdown pass for icons inline with the book?

@ehuss Docs and inline fixup for fontawesome icons have been added to the HTML renderer, so that books using font-awesome will still be able to do so.

@ehuss Now that the fixups are included to allow books that already use font-awesome to continue doing so, and the documentation is written, is there anything else preventing this from being included in the 0.5.0 milestone?

Is there interest in reviving this pull request? I can try to bring these changes up to date with the latest in the repository... 👀

Is there interest in reviving this pull request? I can try to bring these changes up to date with the latest in the repository... 👀

@uncenter yes if you can that would be helpful. Thanks

☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle I rebased and tried to update things. I think I mostly got everything going, but I noticed two issues:

• The spinner (for loading search index) doesn't animate.
• The spacing of the buttons on code blocks doesn't look right.

I ran out of time today to investigate that more. Do you offhand know what's up with the spinner animation?

To fix the spinner animation, this code needs added to the general.css file:

.fa-spin {
	animation: rotating 2s linear infinite;
}

@keyframes rotating {
	from {
		transform: rotate(0deg);
	}
	to {
		transform: rotate(360deg);
	}
}

The fontawesome package happens to include this utility class. Since it's not there any more, we need to provide it ourselves.