Transfer to 2018 edition #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Apr 25, 2019
|
While you're at it, can you apply |
|
Done. |
|
This looks good aside from the change to the |
Centril
approved these changes
Apr 25, 2019
5fdd0c4 to
7e98f1e
Compare
Deny Rust 2018 idioms
* clone_double_ref * expect_fun_call * unnecessary_operation
Fix unrecognized configuration parameter "idle_in_transaction_session_timeout"
76417a9 to
466054c
Compare
We now load all usernames from the team repo, and we import into the database missing users received from the team api.
|
The build is passed. Ready to review again @Centril ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes some clippy issues.
Closes #274 .