Skip to content

tests/ui: A New Order [5/N] #141982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests/ui: A New Order [5/N] #141982

wants to merge 1 commit into from
+135 −188

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 3, 2025

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@Kivooeo Kivooeo changed the title Tf5 tests/ui: A New Order [5/N] Jun 3, 2025
jieyouxu
jieyouxu requested changes Jun 5, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few nits, but feel free to squash already

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025
jieyouxu
jieyouxu approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll r+ after PR CI is green.

@jieyouxu
Copy link
Member

jieyouxu commented Jun 5, 2025

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2025
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 5, 2025

sure, no rush, i will ping rustbot ready when ci passes

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Jun 5, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 5, 2025

📌 Commit 9770f9b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 5, 2025
@GuillaumeGomez
Rollup merge of rust-lang#141982 - Kivooeo:tf5, r=jieyouxu
659c1bd 
`tests/ui`: A New Order [5/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 5, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 5, 2025
@matthiaskrgr
Rollup merge of rust-lang#141982 - Kivooeo:tf5, r=jieyouxu
5e140db 
`tests/ui`: A New Order [5/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

r? ``@jieyouxu``
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kivooeo @jieyouxu @rust-log-analyzer @bors @rustbot