Implement range support in //@ edition
#146166
Open
+258
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
a19047a to
714f2ca
Compare
|
r? fmease |
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
jieyouxu
reviewed
Sep 5, 2025
| ) -> Option<EditionRange> { | ||
| let raw = config.parse_name_value_directive(line, "edition", testfile, line_number)?; | ||
|
|
||
| if let Some((greter_equal_than, lower_than)) = raw.split_once("..") { |
| ) -> Option<EditionRange> { | ||
| let raw = config.parse_name_value_directive(line, "edition", testfile, line_number)?; | ||
|
|
||
| if let Some((greter_equal_than, lower_than)) = raw.split_once("..") { |
There was a problem hiding this comment.
Suggestion: can you just call these lower_bound and upper_bound?
And also leave a quick comment here
// Edition range is half-open: `[lower_bound, upper_bound)`
Comment on lines
1805
to
1806
| (None, Some(_)) => panic!("..edition is not a supported range in //@ edition"), | ||
| (None, None) => panic!("'..' is not a supported range in //@ edition"), |
There was a problem hiding this comment.
Suggestion: can you please use fatal!(), and include the test file path + line number, so the user can have some idea of where this failed?
| enum EditionRange { | ||
| Exact(Edition), | ||
| GreaterEqualThan(Edition), | ||
| Range { greater_equal_than: Edition, lower_than: Edition }, |
There was a problem hiding this comment.
Suggestion: Range { lower_bound: Edition, upper_bound: Edition }
| enum EditionRange { | ||
| Exact(Edition), | ||
| GreaterEqualThan(Edition), | ||
| Range { greater_equal_than: Edition, lower_than: Edition }, |
There was a problem hiding this comment.
Suggestion: can you add a doc comment for this as
/// Half-open range: `[lower_bound, upper_bound)`
|
@jieyouxu this is ready for another review I think 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to solve #145364