Skip to content

rustdoc: even spacing in crate brand heading #146175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rustdoc: even spacing in crate brand heading #146175

wants to merge 1 commit into from

Conversation

notriddle
Copy link
Contributor

Since the search bar and the crate name don't need aligned any more, the layout of the version can be a bit more natural-looking.

This PR is a bit of a follow-up for #115948 and #117906

Before:

image image image

After:

image image image

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@notriddle
rustdoc: even spacing in crate brand heading
1b44fa7 
Since the search bar and the crate name don't need aligned any more,
the layout of the version can be a bit more natural-looking.
@GuillaumeGomez
Copy link
Member

Is there any reason for doing so? That's more complexity for something barely noticeable after all. ^^'

@lolbinarycat
Copy link
Contributor

I honestly can't even tell what's different

@notriddle
Copy link
Contributor Author

notriddle commented Sep 4, 2025 •
edited
Loading

Okay, here it is with some linework added:

Before:
old

After:
new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notriddle @rustbot @GuillaumeGomez @lolbinarycat