Skip to content

Misc LTO cleanups #146209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Misc LTO cleanups #146209

wants to merge 3 commits into from
+44 −77

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 4, 2025 •
edited
Loading

Follow up to #145955.

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This was referenced Sep 4, 2025
Merged
Open
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 5, 2025

Blocked on #146232.

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025
@rustbot

This comment has been minimized.

Sign in to view
@bjorn3
Remove thin_link_data method from ThinBufferMethods
e3d0b7d 
It is only used within cg_llvm.
@bjorn3
Remove want_summary argument from prepare_thin
f2933b3 
It is always false nowadays. ThinLTO summary writing is instead done by
llvm_optimize.
@bjorn3
Move timers into execute_*_work_item
3a1ae06
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3
Copy link
Member Author

bjorn3 commented Sep 6, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 6, 2025
dianqk
dianqk approved these changes Sep 7, 2025
View reviewed changes
Copy link
Member

@dianqk dianqk left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! r=me
r? dianqk

View changes since this review

@rustbot rustbot assigned dianqk and unassigned workingjubilee Sep 7, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 7, 2025

@bors r=dianqk

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit 3a1ae06 has been approved by dianqk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#146209 - bjorn3:lto_refactors5, r=dianqk
92bad93 
Misc LTO cleanups

Follow up to rust-lang#145955.

* Remove want_summary argument from `prepare_thin`.
   Since rust-lang#133250 ThinLTO summary writing is instead done by `llvm_optimize`.
* Two minor cleanups
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2025
Open
bors added a commit that referenced this pull request Sep 7, 2025
@bors
Auto merge of #146304 - matthiaskrgr:rollup-69hs07h, r=matthiaskrgr
12eb345 
Rollup of 4 pull requests

Successful merges:

 - #146170 (fix: offline rustdoc html missing favicon)
 - #146209 (Misc LTO cleanups)
 - #146269 (feat(std): emulate flock for solaris via fcntl)
 - #146297 (Introduce PlaceContext::may_observe_address.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianqk dianqk dianqk approved these changes

Assignees

@dianqk dianqk

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rustbot @bors @dianqk @workingjubilee