Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parentheses when replacing matches!(…, None) with .is_none() #13906

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix parentheses when replacing matches!(…, None) with .is_none() #13906

merged 1 commit into from
Dec 30, 2024

Conversation

samueltardieu
Copy link
Contributor

Proper parentheses need to be added to some expressions in receiver position.

Fix #13902

changelog: [redundant_pattern_matching]: use proper parentheses when suggesting replacing matches!(…, None) by .is_none()

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2024
y21
y21 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@y21 y21 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into rust-lang:master with commit 2aea7a0 Dec 30, 2024
9 checks passed
@samueltardieu samueltardieu deleted the push-uswuxtlzutmp branch December 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redundant_pattern_matching: no is_none() for raw pointer
3 participants
@samueltardieu @rustbot @y21