Update LLVM flags for installing offload from source
#2535
Conversation
Had to change the LLVM cmake command for it to work.
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
|
r? ZuseZ4 |
| @@ -30,7 +30,7 @@ git clone git@github.com:llvm/llvm-project | |||
| cd llvm-project | |||
| mkdir build | |||
| cd build | |||
| cmake -G Ninja ../llvm -DLLVM_TARGETS_TO_BUILD="host,AMDGPU,NVPTX" -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_ENABLE_RUNTIMES="offload,openmp" -DLLVM_ENABLE_PLUGINS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=. | |||
| cmake -G Ninja ../llvm -DLLVM_TARGETS_TO_BUILD="host" -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="AMDGPU;NVPTX" -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_ENABLE_RUNTIMES="offload;openmp" -DLLVM_ENABLE_PLUGINS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=. | |||
There was a problem hiding this comment.
What's the reason for changing AMDGPU and NVPTX to an Experimental targets? They should work as normal ones. The other change , -> ; looks good to me.
There was a problem hiding this comment.
LLVM_TARGETS_TO_BUILD:STRING
Semicolon-separated list of targets to build, or all for building all targets. Case-sensitive. Defaults to all. Example: -DLLVM_TARGETS_TO_BUILD="X86;PowerPC". The full list, as of March 2023, is: AArch64;AMDGPU;ARM;AVR;BPF;Hexagon;Lanai;LoongArch;Mips;MSP430;NVPTX;PowerPC;RISCV;Sparc;SystemZ;VE;WebAssembly;X86;XCore
There was a problem hiding this comment.
Weird, I had to change it to EXPERIMENTAL for them to work. Will verify and get back to you...
There was a problem hiding this comment.
ping @skrobchik did you have a chance to check it?
offload from source
Had to change the LLVM cmake command for it to work.