Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-ndarray/ndarray-linalg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4830306
Choose a base ref
...
head repository: rust-ndarray/ndarray-linalg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 831ecbe
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 17, 2021

  1. Improve stride copying in generalize a bit 

    While still not perfect - that should be solved in upstream ndarray, the
new version is an improvement since it checks the compatibility before
attempting to construct the array.

`.into_raw_vec()` is very hard to use correctly (this is inherent, it's
an access to the raw memory model), so the new version will actually
fail to convert in some cases that were passing as silent errors before
(related to internally sliced arrays, rather uncommon).
    @bluss
    bluss committed May 17, 2021
    Configuration menu
    Copy the full SHA
    831ecbe View commit details
    Browse the repository at this point in the history
Loading