Make stderr logging handle CR-separated progress output #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use cmd_lib::{run_cmd, CmdResult};
#[cmd_lib::main]
fn main() -> CmdResult {
run_cmd!(curl -o /dev/null "https://mirror.aarnet.edu.au/pub/OpenBSD/7.7/amd64/bsd")?;
run_cmd!(dd if=/dev/urandom of=foo bs=1M count=10000 status=progress)?;
run_cmd!(rsync -P foo bar >&2)?;
Ok(())
}
|
|
Thanks for taking time to improve this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
programs like curl(1), rsync(1), and dd(1) have progress output that rewrites one line “in place” by printing
\rOUTPUTinstead ofOUTPUT\n. but StderrThread currently uses BufRead::lines, which only outputs a line when it sees LF (or CR LF), so this kind of progress output is invisible until the command is done (and then it overwrites the[INFO]).this patch reworks StderrThread to treat CR (actually any sequence of CR and/or LF) as a line separator, when capture is false. no changes to the behaviour in capture mode. it also improves the handling of non-UTF-8 output.