Skip to content

Fix parsing of comments in parse/1 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Fix parsing of comments in parse/1 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion native/html5ever_nif/src/flat_dom.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,9 @@ pub fn flat_sink_to_rec_term<'a>(
NodeData::Text { contents } => {
term = StrTendrilWrapper(contents).encode(env);
}
NodeData::Comment { .. } => continue,
NodeData::Comment { contents } => {
term = (atoms::comment(), StrTendrilWrapper(contents)).encode(env);
}
_ => unimplemented!(""),
}

Expand Down
12 changes: 10 additions & 2 deletions test/html5ever_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,17 @@ defmodule Html5everTest do
end

test "parse basic html" do
html = "<html><head></head><body></body></html>"
html = "<html><head></head><body><h1>Hello</h1><!-- my comment --></body></html>"

assert Html5ever.parse(html) == {:ok, [{"html", [], [{"head", [], []}, {"body", [], []}]}]}
assert Html5ever.parse(html) ==
{:ok,
[
{"html", [],
[
{"head", [], []},
{"body", [], [{"h1", [], ["Hello"]}, {:comment, " my comment "}]}
]}
]}
end

test "does not parse with not valid UTF8 binary" do
Expand Down