Skip to content

fix: robust Dockerfile version logic for v prefix handling #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2025
Merged

fix: robust Dockerfile version logic for v prefix handling #262

merged 2 commits into from
Jul 19, 2025

Conversation

overtrue
Copy link
Collaborator

What

  • Make Dockerfile version logic robust: always use a single 'v' prefix for versioned releases, regardless of whether RELEASE is '1.0.0' or 'v1.0.0'.
  • If RELEASE=latest, keep as 'latest'.
  • This prevents double 'v' and ensures correct artifact download.

Why

  • Avoids user confusion and download errors when passing different version formats.
  • Makes Dockerfile more user-friendly and robust.

Test

  • Manually tested with RELEASE=latest, RELEASE=1.0.0, RELEASE=v1.0.0, all download the correct artifact.

No breaking changes. No documentation update required.

@overtrue overtrue merged commit 42b645e into main Jul 19, 2025
11 checks passed
@overtrue overtrue deleted the feat/dockerfile-version-fix branch July 19, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overtrue