-
Notifications
You must be signed in to change notification settings - Fork 342
feat:add mcp integration #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merge brings the complete MCP server implementation with all four S3 tools: - list_buckets: List all accessible S3 buckets with creation dates - list_objects: List objects in a specific S3 bucket with optional prefix filtering - upload_file: Upload a local file to an S3 bucket with comprehensive options - get_object: Get/download objects from S3 with dual modes: - read mode: Direct content retrieval for text files - download mode: Save files locally with improved path display Key features merged: - Full MCP protocol compliance using rmcp SDK v0.3.0 - Intelligent file type detection (Text vs NonText) - Streaming download with absolute path resolution - Comprehensive error handling and user-friendly messages - Complete test coverage for all functionality - Enhanced download mode showing both requested and absolute paths Technical improvements: - Simplified file type detection from 4-variant to binary classification - Improved download_object_to_file method returning (bytes, path) tuple - Enhanced output formatting for better user experience - Robust path canonicalization for security - Support for custom S3 endpoints and RustFS compatibility
damonxue
added a commit
that referenced
this pull request
Jul 28, 2025
fix: download rustfs-console-latest.zip first than build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
#255
Summary of Changes
Added support for the MCP protocol. Currently, MCP via stdio is implemented, and support for streamable HTTP will be considered in the future.
The following features are now supported:
Checklist
cargo fmt --all
cargo clippy --all-targets --all-features -- -D warnings
cargo check --all-targets
Impact