refactor: replace lazy_static with LazyLock and notify crate registry create_targets_from_config
#311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix unzip error * fix url change error fix url change error * Simplify user experience and integrate console and endpoint Simplify user experience and integrate console and endpoint * Add gnu to build.yml
) Resolves #277 - Add --fix flag to automatically fix clippy warnings - Add --allow-dirty flag to run on dirty Git trees - Improves code quality in pre-commit workflow
- Fix Windows zip command issue by using PowerShell Compress-Archive - Add Windows support for OSS upload with ossutil - Replace Chinese comments with English in build.yml - Fix bash syntax error in package_zip function - Improve code formatting and consistency - Update various configuration files for better cross-platform support Resolves Windows build failures in GitHub Actions.
add support on loongarch64
Bumps the dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [hyper-util](https://github.com/hyperium/hyper-util) | `0.1.15` | `0.1.16` | | [rand](https://github.com/rust-random/rand) | `0.9.1` | `0.9.2` | | [serde_json](https://github.com/serde-rs/json) | `1.0.140` | `1.0.141` | | [strum](https://github.com/Peternator7/strum) | `0.27.1` | `0.27.2` | | [sysinfo](https://github.com/GuillaumeGomez/sysinfo) | `0.36.0` | `0.36.1` | Updates `hyper-util` from 0.1.15 to 0.1.16 - [Release notes](https://github.com/hyperium/hyper-util/releases) - [Changelog](https://github.com/hyperium/hyper-util/blob/master/CHANGELOG.md) - [Commits](hyperium/hyper-util@v0.1.15...v0.1.16) Updates `rand` from 0.9.1 to 0.9.2 - [Release notes](https://github.com/rust-random/rand/releases) - [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md) - [Commits](rust-random/rand@rand_core-0.9.1...rand_core-0.9.2) Updates `serde_json` from 1.0.140 to 1.0.141 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.140...v1.0.141) Updates `strum` from 0.27.1 to 0.27.2 - [Release notes](https://github.com/Peternator7/strum/releases) - [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md) - [Commits](Peternator7/strum@v0.27.1...v0.27.2) Updates `sysinfo` from 0.36.0 to 0.36.1 - [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md) - [Commits](GuillaumeGomez/sysinfo@v0.36.0...v0.36.1) --- updated-dependencies: - dependency-name: hyper-util dependency-version: 0.1.16 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: rand dependency-version: 0.9.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: serde_json dependency-version: 1.0.141 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: strum dependency-version: 0.27.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: sysinfo dependency-version: 0.36.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: junxiang Mu <1948535941@qq.com>
Signed-off-by: junxiang Mu <1948535941@qq.com>
Signed-off-by: junxiang Mu <1948535941@qq.com>
# Conflicts: # Cargo.lock # crates/e2e_test/Cargo.toml # crates/s3select-query/src/lib.rs
* fix * fix * fix * fix delete-marker expiration. add api_restore. * fix * time retry object upload * lock file * make fmt * fix * restore object * fix * fix * serde-rs-xml -> quick-xml * fix * checksum * fix * fix * fix * fix * fix * fix * fix
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # Cargo.lock # crates/checksums/Cargo.toml
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive refactor to modernize the RustFS codebase by replacing lazy_static with Rust's stable LazyLock and significantly refactoring the notification system's target registry functionality.
- Replaced
lazy_staticmacros with standard libraryLazyLockfor improved performance and reduced dependencies - Refactored notification target creation to support concurrent processing and environment variable-based configuration
- Updated dependency management and build configuration across multiple crates
Reviewed Changes
Copilot reviewed 45 out of 49 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/run.sh | Updated logging configuration and added multiple webhook notification targets |
| rustfs/src/main.rs | Updated global configuration variable references to use new naming convention |
| rustfs/src/config/mod.rs | Updated default value reference for console enable configuration |
| rustfs/src/admin/mod.rs | Added new notification target management API endpoints |
| rustfs/src/admin/handlers/event.rs | Updated imports and configuration key references |
| crates/utils/src/dirs.rs | Added comprehensive log directory resolution functionality |
| crates/protos/src/main.rs | Updated protobuf build configuration and dependency |
| crates/protos/Cargo.toml | Replaced tonic-build with tonic-prost-build |
| crates/obs/src/telemetry.rs | Updated log directory configuration to use new utility functions |
| crates/obs/src/sinks/mod.rs | Updated default value references and improved configuration handling |
| crates/obs/src/sinks/file.rs | Enhanced file sink logging with path information |
| crates/obs/src/config.rs | Major refactor to use environment variable constants and improved configuration management |
| crates/obs/Cargo.toml | Updated feature dependencies |
| crates/notify/src/target/mod.rs | Added boolean parsing utility function |
| crates/notify/src/registry.rs | Complete refactor of target creation to support concurrent processing and environment variable merging |
| crates/notify/src/integration.rs | Commented out configuration saving and updated target creation comments |
| crates/notify/src/factory.rs | Simplified factory implementations to use merged configuration directly |
| crates/notify/src/error.rs | Added new error types and fixed import |
| crates/notify/examples/ | Updated imports to use new configuration constants |
| crates/notify/Cargo.toml | Added futures dependency and reordered dependencies |
| crates/mcp/Cargo.toml | Updated dependencies to use workspace versions |
| crates/ecstore/src/store.rs | Updated global storage class variable reference |
| crates/ecstore/src/set_disk.rs | Updated global storage class references and improved imports |
| crates/ecstore/src/global.rs | Removed unused constant and updated lazy_static usage |
| crates/ecstore/src/config/ | Replaced lazy_static with LazyLock across all configuration modules |
| crates/e2e_test/Cargo.toml | Updated dependencies to use workspace versions |
| crates/config/src/observability/ | Restructured observability configuration to use constants instead of structs |
| crates/config/src/notify/ | Added valid field collections for webhook and MQTT targets |
| crates/config/src/constants/app.rs | Updated application name and added console enable default |
| crates/config/Cargo.toml | Removed unused serde dependencies |
| crates/checksums/Cargo.toml | Updated dependencies to use workspace versions |
| Cargo.toml | Updated workspace dependencies and added cargo-shear metadata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo check --all-targetsImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.