refactor: replace lazy_static with LazyLock
#318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `lazy_static` with `LazyLock`. Compile time may reduce a little. See rust-lang-nursery/lazy-static.rs#214
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to replace the lazy_static macro with Rust's standard library LazyLock type for lazy initialization. This modernizes the code to use the stable stdlib feature introduced in Rust 1.80, potentially reducing compile time by removing an external dependency.
- Migrates all static metric descriptors from
lazy_static!macro toLazyLock::new() - Removes the
lazy_staticdependency from Cargo.toml - Updates benchmark code to use
std::hint::black_boxinstead ofcriterion::black_box
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/obs/src/metrics/*.rs | Convert lazy_static metric descriptors to LazyLock with improved documentation |
| crates/obs/Cargo.toml | Remove lazy_static dependency |
| crates//benches/.rs | Update black_box import to use std::hint instead of criterion |
| Cargo.toml | Update criterion and rmcp versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
lazy_staticwithLazyLock.Compile time may reduce a little.
See rust-lang-nursery/lazy-static.rs#214
Type of Change
Related Issues
Summary of Changes
Checklist
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo check --all-targetsImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.