chore: add tls log and removing unused crates #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # rustfs/src/server/http.rs
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors TLS logging functionality and removes unused dependencies across the codebase. It introduces conditional TLS key logging based on environment variables and consolidates enable state handling through a centralized enum.
- Adds conditional TLS key logging controlled by the
RUSTFS_TLS_KEYLOGenvironment variable - Introduces a comprehensive
EnableStateenum to standardize boolean state parsing across the codebase - Removes unused dependencies and features to reduce build overhead
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rustfs/src/server/http.rs | Adds conditional TLS key logging and improves TLS handshake failure categorization with metrics |
| rustfs/Cargo.toml | Removes unused feature flags including tls_fallback |
| crates/utils/src/certs.rs | Implements tls_key_log() function to check environment variable |
| crates/config/src/constants/env.rs | Adds EnableState enum with comprehensive boolean state variants |
| crates/config/src/constants/tls.rs | Defines TLS-related environment variable constants |
| crates/notify/src/registry.rs | Refactors to use the new EnableState enum instead of hardcoded strings |
| Multiple Cargo.toml files | Removes unused dependencies across various crates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo check --all-targetsImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.