feat: support conditional writes #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will review this PR in a few days. |
|
@guojidan If the code review is complete and all aspects of the functionality are ready, you can merge the feature. |
guojidan
requested changes
Aug 19, 2025
crates/ecstore/src/set_disk.rs
Outdated
| @@ -3218,6 +3219,42 @@ impl SetDisks { | |||
| obj?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn check_write_precondition(&self, bucket: &str, object: &str, mut opts: ObjectOptions) -> Option<StorageError> { | |||
| let http_preconditions = opts.http_preconditions.unwrap(); | |||
crates/ecstore/src/set_disk.rs
Outdated
| @@ -3218,6 +3219,42 @@ impl SetDisks { | |||
| obj?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn check_write_precondition(&self, bucket: &str, object: &str, mut opts: ObjectOptions) -> Option<StorageError> { | |||
There was a problem hiding this comment.
You should use opts: &ObjectOptions, and later use let opts = opts.clone(), because we do not intend to modify the incoming opts itself.
There was a problem hiding this comment.
Thanks for your advice! I've fixed them
|
LGTM,
|
I'll add the tests sometime this week, kind of busy today~ |
|
I've added some e2e tests~ |
houseme
added a commit
that referenced
this pull request
Aug 26, 2025
* 'main' of github.com:rustfs/rustfs: feat: support conditional writes (#409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
#406
Summary of Changes
When executing
PutObjectandCompleteMultipartUpload, if theIf-None-MatchorIf-Matchheader is set, check the etag of the object before proceeding. The implementation strategy comes from MinIO.I've done some tests with the following settings:
PutObjectandCompleteMultipartUploadLooks good for now.
Any further tests and comments are welcome!
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.