Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test keys into tests #44

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Move test keys into tests #44

merged 1 commit into from
Apr 7, 2024

Conversation

djc
Copy link
Member

@djc djc commented Apr 7, 2024 •
edited
Loading

IMO this is a more appropriate/conventional home for test data (compared to inside src).

(Context: looking at rustls/rustls#1462 again.)

@djc djc requested review from cpu and ctz April 7, 2024 11:26
ctz
ctz approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like behaviour tests that strictly use the public API should also not be in src/ (rationale: it's easy to accidentally neglect to export a public API)

cpu
cpu approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like behaviour tests that strictly use the public API should also not be in src/

Agreed. Moving some of the existing tests seems like a good follow-up.

@djc djc added this pull request to the merge queue Apr 7, 2024
@djc
Copy link
Member Author

djc commented Apr 7, 2024

I'll follow up with those changes.

Merged via the queue into main with commit 8683cc7 Apr 7, 2024
26 checks passed
@djc djc deleted the tests-keys branch April 7, 2024 15:11
@djc djc mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz