Skip to content

Conversation

hoebbelsB
Copy link
Member

No description provided.

@github-actions github-actions bot added </> Template @rx-angular/template related { } State @rx-angular/state related 🚀 ISR 🛠️ CDK CDK related labels May 28, 2024
@hoebbelsB hoebbelsB linked an issue May 28, 2024 that may be closed by this pull request
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should include the breaking change in order to follow semver. The rest looks good!

Edit: The new dependency @angular/build seems to be missing.

@JeanMeche
Copy link
Contributor

@angular-devkit/build-angular has @angular/build as dependency, so it shouldn't be an issue, right ?

Copy link

nx-cloud bot commented May 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b7ec2a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@hoebbelsB hoebbelsB merged commit c2b2873 into main May 31, 2024
@hoebbelsB hoebbelsB deleted the upgr-18 branch May 31, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ CDK CDK related 🚀 ISR { } State @rx-angular/state related </> Template @rx-angular/template related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 18
3 participants