Skip to content

feat(state): expose asReadOnly() when create state instance using functional approach #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michaelbe812
Copy link
Contributor

closes #1789

@github-actions github-actions bot added { } State @rx-angular/state related 🛂 Test Unit tests, e2e tests, integration tests, test coverage labels Sep 30, 2024
Copy link

nx-cloud bot commented Sep 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 60c4aa4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@hoebbelsB
Copy link
Member

hey @mikelgo thanks for the PR! will merge as soon as the formatting issues are gone :)

@michaelbe812 michaelbe812 force-pushed the feat/expose-as-readonly-on-functional-state branch from 9e19fca to 60c4aa4 Compare September 30, 2024 08:15
@michaelbe812
Copy link
Contributor Author

hey @mikelgo thanks for the PR! will merge as soon as the formatting issues are gone :)

You're welcome! Sure! I just pushed the changes, they should be gone now.

Sorry for the inconvenience, I had some local issues with yarn and thus those issues :)

@hoebbelsB hoebbelsB merged commit 1145c8c into rx-angular:main Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
{ } State @rx-angular/state related 🛂 Test Unit tests, e2e tests, integration tests, test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RxAngular/State: functional rxState does not expose asReadOnly()
3 participants