Skip to content

Fix/some issues in demo app #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix/some issues in demo app #1834

merged 3 commits into from
Jan 6, 2025

Conversation

michaelbe812
Copy link
Contributor

fixes #1833

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 6, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a7a95fc.

Command Status Duration Result
nx affected -t lint build test component-test e... ✅ Succeeded 1m 14s View ↗
nx build docs ✅ Succeeded 33s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 06:03:50 UTC

@michaelbe812 michaelbe812 mentioned this pull request Jan 6, 2025
Merged
hoebbelsB
hoebbelsB approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@hoebbelsB hoebbelsB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@hoebbelsB hoebbelsB merged commit 303df1e into rx-angular:main Jan 6, 2025
7 checks passed
@michaelbe812 michaelbe812 deleted the fix/some-issues-in-demo-app branch January 8, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoebbelsB hoebbelsB hoebbelsB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(demos): resetting demo state throws error
2 participants
@michaelbe812 @hoebbelsB