fix(list-manager): fix list manager return value #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation returns
[]
when no changes were detected from theIterableDiffer
. This causes theswitchMap
to stop emitting values which in turn results in norenderCallback
called.When u put an empty array
[]
into therxFor
directive (aka listManager), therenderCallback
won't emit properly. Imho a new value which results in no change should triggerrenderCallback
since the change got processed.Fix