Skip to content

fix(services): drop empty async validator argument #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2023
Merged

fix(services): drop empty async validator argument #624

merged 2 commits into from
Feb 20, 2023

Conversation

alizedebray
Copy link
Contributor

the validators argument of the FormControl should not be used when validators are configured in the options argument.
Fixes #612

Please check if your PR fulfills the following requirements:

alizedebray and others added 2 commits January 16, 2023 16:10
@alizedebray
fix(services): drop empty async validator argument
7fe5196 
the validators argument of the FormControl should not be used when
validators are configured in the options argument.
Fixes rxweb#612
@alizedebray
Merge branch 'master' into fix-warning-about-usage-of-options-and-asy…
732ab52 
…nc-validators
@ajayojha ajayojha merged commit a07de9c into rxweb:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulburz paulburz paulburz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning about usage of options and async validators
3 participants
@alizedebray @paulburz @ajayojha