Skip to content

Validate correct objects in tests #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Validate correct objects in tests #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ describe('NodeRSA', function () {

it('should load public key from (not trimmed) PKCS8-PEM string', function () {
publicNodeRSA = new NodeRSA(publicKeyPEMNotTrimmed);
assert.instanceOf(privateNodeRSA.keyPair, Object);
assert.instanceOf(publicNodeRSA.keyPair, Object);
assert(publicNodeRSA.isPublic());
assert(publicNodeRSA.isPublic(true));
assert(!publicNodeRSA.isPrivate());
Expand Down Expand Up @@ -345,7 +345,7 @@ describe('NodeRSA', function () {
it('should gracefully handle data outside of encapsulation boundaries for pkcs1 public keys', function () {
let publicFileWithNoise = 'Lorem ipsum' + fs.readFileSync(keysFolder + 'public_pkcs1.pem') + 'dulce et decorum';
let publicNodeRSA = new NodeRSA(publicFileWithNoise);
assert.instanceOf(privateNodeRSA.keyPair, Object);
assert.instanceOf(publicNodeRSA.keyPair, Object);
assert(publicNodeRSA.isPublic());
assert(publicNodeRSA.isPublic(true));
assert(!publicNodeRSA.isPrivate());
Expand All @@ -360,7 +360,7 @@ describe('NodeRSA', function () {
it('should gracefully handle data outside of encapsulation boundaries for pkcs8 public keys', function () {
let publicFileWithNoise = 'Lorem ipsum' + fs.readFileSync(keysFolder + 'public_pkcs8.pem') + 'dulce et decorum';
let publicNodeRSA = new NodeRSA(publicFileWithNoise);
assert.instanceOf(privateNodeRSA.keyPair, Object);
assert.instanceOf(publicNodeRSA.keyPair, Object);
assert(publicNodeRSA.isPublic());
assert(publicNodeRSA.isPublic(true));
assert(!publicNodeRSA.isPrivate());
Expand Down