Skip to content

Conversation

zumesh20
Copy link

@zumesh20 zumesh20 commented Sep 6, 2019

use name from component constructor if its not provided when calling registerComponent

closes: #1033

Details

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

use name from component constructor if its not provided when calling registerComponent

closes: salesforce#1033
@salesforce-cla
Copy link

salesforce-cla bot commented Sep 6, 2019

Thanks for the contribution! Before we can merge this, we need @zumesh20 to sign the Salesforce.com Contributor License Agreement.

@rtm
Copy link

rtm commented Sep 6, 2019

What is the problem being solved here?

@zumesh20 zumesh20 closed this Sep 6, 2019
@caridy
Copy link
Collaborator

caridy commented Sep 6, 2019

@zumesh20 we were planning to do this at some point, but your PR looks good. @ekashida can you take care of this?

@ekashida
Copy link
Member

ekashida commented Sep 9, 2019

@zumesh20 would you like to sign the CLA and reopen the PR?

@zumesh20
Copy link
Author

zumesh20 commented Sep 9, 2019

Thanks @caridy, @ekashida. I am checking with my employer about CLA. Once I get approval, I will reopen the PR if it's still applicable.

@Gr8Gatsby
Copy link

@zumesh20 checking in with you to see if you found out about the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningElement.toString always returns undefined
5 participants