fix(synthetic-shadow): dont add key for slotted text vnode #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
reviewed
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When vnodes are allocated in slots (synthetic-shadow only), the process rewrites the vnode key, in the case of text vnodes (they don't have key), it will make 2 different text vnodes in the same slot, to have the same key.
Later on in this section diffing algo, createKeyToOldIdx will map incorrectly those 2 nodes, causing the algo to patch the incorrect vnode, which eventually triggers an error.
This PR fixes the issue by not adding the slot key for text nodes.
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.GUS item
W-7292159