Skip to content

test(engine-server): Improve test coverage #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2020
Merged

test(engine-server): Improve test coverage #1950

merged 3 commits into from
Jun 30, 2020

Conversation

pmdartus
Copy link
Member

Details

  • Add missing test coverage for style attribute
  • Add missing test coverage for noop component method: addEventListener, removeEventListener
  • Remove unused tagName renderer API. This API is not used since bafb31c.

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

GUS work item

W-7552550

ekashida
ekashida approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pmdartus pmdartus merged commit bd80057 into master Jun 30, 2020
@pmdartus pmdartus deleted the pmdartus/test-coverage branch June 30, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekashida ekashida ekashida approved these changes

@jodarove jodarove Awaiting requested review from jodarove

@ravijayaramappa ravijayaramappa Awaiting requested review from ravijayaramappa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmdartus @ekashida