Skip to content

chore(lwc): specify dom lib for types.d.ts #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

chore(lwc): specify dom lib for types.d.ts #1993

merged 1 commit into from
Jul 27, 2020

Conversation

ekashida
Copy link
Member

Details

The lwc dist package has a type definition file which requires DOM types.

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

GUS work item

W-7391508

@ekashida ekashida mentioned this pull request Jul 26, 2020
Closed
@salesforce-best-lwc-internal
Copy link

🥳 Performance Improvement

Best has detected that there is a 9.2% performance improvement across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

@lwc/engine-dom

✅ Improvements base (6a8d606) target (e8905bb) trend
table-append-1k.benchmark/benchmark-table/append/1k 274.74 (± 1.85ms) 241.06 (± 2.15ms) -33.7ms (12.3%)
table-clear-1k.benchmark/benchmark-table/clear/1k 16.71 (± 0.16ms) 13.14 (± 0.22ms) -3.6ms (21.3%)
table-create-10k.benchmark/benchmark-table/create/10k 1454.07 (± 15.75ms) 1273.99 (± 8.38ms) -180.1ms (12.4%)
table-create-1k.benchmark/benchmark-table/create/1k 172.27 (± 1.08ms) 145.58 (± 2.15ms) -26.7ms (15.5%)
table-update-10th-1k.benchmark/benchmark-table/update-10th/1k 145.71 (± 1.82ms) 129.68 (± 1.47ms) -16.0ms (11.0%)
tablecmp-append-1k.benchmark/benchmark-table-component/append/1k 378.76 (± 3.40ms) 342.39 (± 2.07ms) -36.4ms (9.6%)
tablecmp-clear-1k.benchmark/benchmark-table-component/clear/1k 9.71 (± 0.17ms) 6.46 (± 0.23ms) -3.2ms (33.4%)
tablecmp-create-10k.benchmark/benchmark-table-component/create/10k 2054.04 (± 14.26ms) 1845.50 (± 9.49ms) -208.5ms (10.2%)
tablecmp-create-1k.benchmark/benchmark-table-component/create/1k 244.32 (± 1.24ms) 208.20 (± 2.39ms) -36.1ms (14.8%)
tablecmp-update-10th-1k.benchmark/benchmark-table-component/update-10th/1k 128.16 (± 1.02ms) 111.26 (± 1.37ms) -16.9ms (13.2%)
wc-append-1k.benchmark/benchmark-table-wc/append/1k 527.03 (± 10.61ms) 482.39 (± 9.41ms) -44.6ms (8.5%)
wc-clear-1k.benchmark/benchmark-table-wc/clear/1k 26.73 (± 0.38ms) 21.66 (± 0.25ms) -5.1ms (19.0%)
wc-create-10k.benchmark/benchmark-table-wc/create/10k 3463.78 (± 6.09ms) 3210.18 (± 11.61ms) -253.6ms (7.3%)
wc-create-1k.benchmark/benchmark-table-wc/create/1k 385.18 (± 2.11ms) 350.51 (± 4.11ms) -34.7ms (9.0%)
wc-update-10th-1k.benchmark/benchmark-table-wc/update-10th/1k 128.91 (± 0.75ms) 110.17 (± 0.66ms) -18.7ms (14.5%)

@lwc/engine-server

✅ Improvements base (6a8d606) target (e8905bb) trend
table-render-10k.benchmark/benchmark-table/render/10k 500.19 (± 14.56ms) 452.50 (± 24.48ms) -47.7ms (9.5%)

caridy
caridy approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@caridy caridy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diervo
Copy link
Contributor

diervo commented Jul 27, 2020 via email

@ekashida ekashida merged commit d500814 into master Jul 27, 2020
@ekashida ekashida deleted the ekashida/types-for-lwc-dist-package branch July 27, 2020 19:36
@ekashida
Copy link
Member Author

Confirmed that the dist files generated before and after this change are identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caridy caridy caridy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekashida @diervo @caridy