chore: update webdriverio to v8 #3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jun 15, 2023
| @@ -47,7 +47,7 @@ const wdSuites = suites.reduce((seed, suite) => { | |||
| exports.config = { | |||
| logLevel: 'warn', | |||
|
|
|||
| specs: ['./src/**/*.spec.js'], | |||
| specs: ['../src/**/*.spec.js'], | |||
There was a problem hiding this comment.
Now relative to the config file
nolanlawson
commented
Jun 15, 2023
| @@ -17,7 +17,7 @@ module.exports = function (browser) { | |||
| browser.addCommand( | |||
| 'focus', | |||
| function () { | |||
| return this.execute(function (target) { | |||
| return browser.execute(function (target) { | |||
There was a problem hiding this comment.
I think this just happened to work – execute should be on the browser, not this (which is an element).
|
/nucleus test |
|
/nucleus ignore --reason 'downstream is failing for unrelated reason' |
|
/nucleus test |
ravijayaramappa
approved these changes
Jun 16, 2023
ekashida
approved these changes
Jun 16, 2023
|
/nucleus test |
|
/nucleus ignore --reason 'downstream is failing due to flapper' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updates WebDriverio to v8, and fixes some minor breaking changes in our tests.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?