fix: remove redundant optional chaining on process.env which is breaking testing #5459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
reviewed
Aug 14, 2025
| @@ -62,6 +62,6 @@ export function registerLwcStyleComponent() { | |||
| } | |||
|
|
|||
| // Only used in LWC's Karma tests | |||
| if (typeof process !== 'undefined' && process?.env?.NODE_ENV === 'test-karma-lwc') { | |||
| if (typeof process !== 'undefined' && process.env.NODE_ENV === 'test-karma-lwc') { | |||
There was a problem hiding this comment.
Suggested change
| if (typeof process !== 'undefined' && process.env.NODE_ENV === 'test-karma-lwc') { | |
| if (typeof process === 'object' && typeof process?.env === 'object' && process.env && process.env.NODE_ENV === 'test-karma-lwc') { |
I forget who, but someone runs LWC in an environment with process but not process.env, so we need to be extra verbose in this check. (This also bit us in #5281).
There was a problem hiding this comment.
Got you, thanks. Switched it to use the same check as that PR.
wjhsf
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Optional chaining on process.env fails tests due to rollup transformations which do not match. The optional checks are redundant given the preceding typeof check.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-19309489