-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix interactivity in aptpkg #15584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interactivity in aptpkg #15584
Conversation
@@ -502,7 +503,9 @@ def install(name=None, | |||
if refreshdb: | |||
refresh_db() | |||
|
|||
__salt__['cmd.run'](cmd, env=kwargs.get('env'), python_shell=False) | |||
env = _parse_env(kwargs.get('env')) | |||
env.update(copy.deepcopy(DPKG_ENV_VARS)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to deepcopy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... hmm, cmdmod messes with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
factorisation, i was writing the same code as in cmdmod.
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test PASSed. |
Thanks @kiorky ! |
another regression fixed in aptpkg (multiple sources of interactivity)