Skip to content

Fix interactivity in aptpkg #15584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2014
Merged

Fix interactivity in aptpkg #15584

merged 2 commits into from
Sep 9, 2014

Conversation

kiorky
Copy link
Contributor

@kiorky kiorky commented Sep 8, 2014

another regression fixed in aptpkg (multiple sources of interactivity)

@@ -502,7 +503,9 @@ def install(name=None,
if refreshdb:
refresh_db()

__salt__['cmd.run'](cmd, env=kwargs.get('env'), python_shell=False)
env = _parse_env(kwargs.get('env'))
env.update(copy.deepcopy(DPKG_ENV_VARS))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to deepcopy?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... hmm, cmdmod messes with it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factorisation, i was writing the same code as in cmdmod.

@ghost
Copy link

ghost commented Sep 8, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7728/

@ghost
Copy link

ghost commented Sep 8, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7729/

thatch45 added a commit that referenced this pull request Sep 9, 2014
Fix interactivity in aptpkg
@thatch45 thatch45 merged commit 3b8449d into saltstack:develop Sep 9, 2014
@thatch45
Copy link
Contributor

thatch45 commented Sep 9, 2014

Thanks @kiorky !
Sorry I am being slow on the other ones, I have been swamped lately and I need to review them a little more carefully

@rallytime rallytime added the ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. label Oct 3, 2014
thatch45 added a commit that referenced this pull request Oct 3, 2014
@kiorky kiorky deleted the b3 branch October 10, 2014 07:42
@kiorky kiorky restored the b3 branch October 10, 2014 07:42
@kiorky kiorky deleted the b3 branch October 10, 2014 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants