Skip to content

salt-cloud GCE : Support for addresses & internal IPs #18650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2014

Conversation

bbeausej
Copy link

@bbeausej bbeausej commented Dec 2, 2014

Here is a small patch that enables all the GCE Address manipulation function from salt-cloud.
Also allows for creating VMs and Load Balancers with named fixed IP addresses inside GCE.

The patch also includes a cloud provider parameter "ssh_interface" that specifies if the hosts will use their private IPs or public IPs for salt communication. (Just like the EC2 module does.)

Also followed in with a docs update.

Hopefully this is helpful!

-b

Benoit Beausejour added 2 commits December 2, 2014 15:25
…dule).

- GCEAddress handling with libcloud
  - Allow create,delete address in GCE
  - Allow creation of VM and LB with named fixed GCEAddress
  - Support for fixed address
  - New salt function for create_address, delete_address, show_address
@ghost
Copy link

ghost commented Dec 2, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/10964/

@rallytime
Copy link
Contributor

Thanks for the pull request @bbeausej! Would you mind grabbing the pylint errors here?
https://jenkins.saltstack.com/job/salt-pr-lint/9827/violations/file/salt/cloud/clouds/gce.py/

@ghost
Copy link

ghost commented Dec 3, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/10987/

@bbeausej
Copy link
Author

bbeausej commented Dec 3, 2014

Hi there! Amended the pull to fix the pylint errors. Thanks for pointing me at the right report :) Not familiar with the build check system at all. Still failures though...not sure where to look to make sure the code changes aren't responsible.

@ghost
Copy link

ghost commented Dec 3, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/10988/

@rallytime
Copy link
Contributor

@bbeausej Thanks for fixing up the pylint! Those other errors are unrelated to your changes, so no worries here! We're working on getting those fixed up. Thanks for contributing!

thatch45 added a commit that referenced this pull request Dec 4, 2014
salt-cloud GCE : Support for addresses & internal IPs
@thatch45 thatch45 merged commit e6f843d into saltstack:develop Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants