Always run download_packages() after executing buildpackage SLS #18663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By restricting this function call to when the script is successful, we end up losing the log file from buildpackage.py when it fails, making it next to impossible to troubleshoot. This commit makes jenkins retrieve at least the log file, no matter what happens.
823ebb7 to
5c864fa
Compare
|
Test PASSed. |
|
Test PASSed. |
|
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
|
Sounds good to me. |
thatch45
added a commit
that referenced
this pull request
Dec 4, 2014
…stment Always run download_packages() after executing buildpackage SLS
s0undt3ch
added a commit
to vmware-archive/salt-testing
that referenced
this pull request
Dec 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By restricting this function call to when the script is successful, we end up
losing the log file from buildpackage.py when it fails, making it next to impossible to
troubleshoot. This commit makes jenkins retrieve at least the log file, no
matter what happens.
ping @s0undt3ch @rallytime