Skip to content

unquote venv mod commands #18776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2014
Merged

unquote venv mod commands #18776

merged 2 commits into from
Dec 9, 2014

Conversation

jfindlay
Copy link
Contributor

@jfindlay jfindlay commented Dec 5, 2014

unquote venv mod commands

@jfindlay jfindlay added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Dec 5, 2014
@ghost
Copy link

ghost commented Dec 5, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/11088/

@thatch45
Copy link
Contributor

thatch45 commented Dec 8, 2014

@jfindlay these test failures appear to be related

@ghost
Copy link

ghost commented Dec 9, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/11169/

@rallytime rallytime closed this Dec 9, 2014
@rallytime rallytime reopened this Dec 9, 2014
@ghost
Copy link

ghost commented Dec 9, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/11170/

@rallytime
Copy link
Contributor

Woot! Thanks @jfindlay!

rallytime pushed a commit that referenced this pull request Dec 9, 2014
Merge pull request #18776 from jfindlay/quote_virtualenv
48e1df7 
unquote venv mod commands
@rallytime rallytime merged commit 48e1df7 into saltstack:2014.7 Dec 9, 2014
This was referenced Dec 9, 2014
Merged
Merged
@rallytime rallytime self-assigned this Dec 11, 2014
@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Dec 11, 2014
@rallytime rallytime removed their assignment Dec 11, 2014
thatch45 added a commit that referenced this pull request Dec 12, 2014
@thatch45
Merge pull request #18916 from rallytime/cp-18776
791cae1 
Backport #18776 to 2014.1
@jfindlay jfindlay deleted the quote_virtualenv branch March 24, 2015 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfindlay @thatch45 @rallytime @cachedout