Correct issue where duplicate items in grains list during state run will result in duplicate grains #31471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 24, 2016 11:43
Insert grains into context so that we can know if we're duplicating during multiple inserts in a state run. Refs saltstack#31427
… a problem with context in test suite
|
@cachedout "That needs to be fixed first." Do you mean that should be fixed before merging this, or that it needs to be fixed in general before the test will run? |
|
In general. |
rallytime
pushed a commit
that referenced
this pull request
Feb 25, 2016
Correct issue where duplicate items in grains list during state run will result in duplicate grains
|
I am adding the "Needs Testcase" label here to indicate that we need to fix the skipped test as mentioned above. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #31427
The test written for this is currently disabled because something is going in on the test suite that seems to be resetting context. That needs to be fixed first.