[3006.x] Ensure on rpm and deb systems, that user and group for existing Salt, is maintained on upgrade #66218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
approved these changes
Jul 15, 2024
This was referenced Jul 15, 2024
9 tasks
barneysowood
added a commit
to barneysowood/salt
that referenced
this pull request
Apr 17, 2025
Enables tests for systemd status (enabled, active etc). These were added in saltstack#66218 but disabled. We should actually be testing this.
This was referenced Apr 17, 2025
barneysowood
added a commit
to barneysowood/salt
that referenced
this pull request
May 6, 2025
Enables tests for systemd status (enabled, active etc). These were added in saltstack#66218 but disabled. We should actually be testing this.
barneysowood
added a commit
to barneysowood/salt
that referenced
this pull request
May 7, 2025
Enables tests for systemd status (enabled, active etc). These were added in saltstack#66218 but disabled. We should actually be testing this.
barneysowood
added a commit
to barneysowood/salt
that referenced
this pull request
May 21, 2025
Enables tests for systemd status (enabled, active etc). These were added in saltstack#66218 but disabled. We should actually be testing this.
barneysowood
added a commit
to barneysowood/salt
that referenced
this pull request
May 29, 2025
Enables tests for systemd status (enabled, active etc). These were added in saltstack#66218 but disabled. We should actually be testing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On upgrading on Redhat and Debian families, ensures that existing permissions (user, group) are preserved.
What issues does this PR fix or reference?
Fixes: #65264
Previous Behavior
Upgrades would force Salt directories etc. permissions user:group to salt:salt
New Behavior
Upgrades of Salt, now note the permissions (user:group) of Salt directories and preserves those permissions.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.