Enable pkg tests for systemd status on upgrade #67968
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
31382c6 to
ebdaa0c
Compare
ebdaa0c to
a02bdef
Compare
a02bdef to
e514927
Compare
Removes tests for services maintaing active/inactive states over upgrades as this functionality was removed from the packages (saltstack#66688)
Adds a fixture to disable /usr/sbin/policy-rc.d - on the container images we're using this returns an exitcode of 1001, which prevents dpkg from running service restarts on installs/upgrades, which makes the system behave differently to a real system.
4fbe824 to
05bf6bc
Compare
Adds test for masking services to ensure that is preserved on upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables tests for systemd status (enabled, active etc). These were added in #66218 but disabled. We should actually be testing this.
Spotted this when reviewing #66688 - I was surprised that wasn't breaking tests. Assume the intent was that this should be enabled once #66218 was merged and pkg tests were running again
Previous Behavior
Tests for maintaining status of systemd services on upgrade were not being run
New Behavior
Tests are now being run
Merge requirements satisfied?
N/A
Commits signed with GPG?
Yes/No