[3006.x] Python 3.11 #68018
Open
[3006.x] Python 3.11 #68018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-picked ff296ea to fix the failing Windows tests |
twangboy
requested changes
May 14, 2025
| @@ -12,6 +12,8 @@ | |||
| from tests.support.mixins import SaltReturnAssertsMixin | |||
| from tests.support.runtests import RUNTIME_VARS | |||
|
|
|||
| KEY = "AAAAC3NzaC1lZDI1NTE5AAAAIEmY2ZOSneFGN+b7+S9eLPGOqPF2yl9AgTCkZHuWKjC5" | |||
There was a problem hiding this comment.
Isn't it bad to create a global variable in the test suite
There was a problem hiding this comment.
Maybe it's not very pytest-ee. Though, the alternative of making a fixture also creates a global variable. I.E. Function definitions are also variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the python shipped with 3006 release from 3.10 to 3.11
Why would we make this change in 3006.x?
We've had to postpone several milestones on the way to a 3008 LTS release. This means that we'll now be on the hook for maintaining 3006 LTS with security update longer than Python 3.10 will receive security updates.