yumpkg list_upgrades do not show held packages #68143
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
requested changes
Jul 3, 2025
bdrx312
reviewed
Aug 15, 2025
| @@ -1037,7 +1037,7 @@ def list_upgrades(refresh=True, **kwargs): | |||
|
|
|||
| cmd = ["--quiet"] | |||
| cmd.extend(options) | |||
| cmd.extend(["list", "--upgrades" if _yum() in ("dnf", "dnf5") else "updates"]) | |||
| cmd.extend(["check-update"] if _yum() in ("dnf", "dnf5") else ["list", "updates"]) | |||
There was a problem hiding this comment.
The output of check-update is not just a drop in replacement for list --upgrades. check-update also includes an Obsoleting Packages section at the bottom that includes the currently installed package and the newer version package from the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
uses
dnf check-updateto list packages with available updates vsdnf list --upgradesto ensure held packages are not listed as available upgradesWhat issues does this PR fix or reference?
fixes #68138
Previous Behavior
The previous behavior used
dnf list --upgradeswhich would show versionlocked or held packages to be shown as having upgrades availableNew Behavior
uses
dnf check-updatewhich takes version locking into accountMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No