Skip to content

(3007.x) Ensure test value returns only boolean values #68174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

(3007.x) Ensure test value returns only boolean values #68174

wants to merge 3 commits into from

Conversation

DdangJin
Copy link
Contributor

@DdangJin DdangJin commented Jul 11, 2025 •
edited
Loading

What does this PR do?

This PR for the 3007.x branch applies the same modifications to LoadedCoro as the changes I previously submitted(#68122).

Normalize test value to strictly boolean output

What issues does this PR fix or reference?

Fixes #68121

Previous Behavior

For more details, please refer to the previous PR, #68122.

New Behavior

For more details, please refer to the previous PR, #68122.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@DdangJin DdangJin requested a review from a team as a code owner July 11, 2025 07:05
@DdangJin DdangJin mentioned this pull request Jul 11, 2025
Open
9 tasks
@DdangJin
Copy link
Contributor Author

@twangboy @dwoz
It's a PR that's made corrections in 3006.x PR #68122 to fit 3007.x. Can you review this?

@twangboy
Copy link
Contributor

These changes will go into 3007.x and master branch from merge forwards. No need to open another PR.

3007.x -> master: #68169
3006.x -> 3007.x: #68166

@twangboy twangboy closed this Jul 22, 2025
@DdangJin
Copy link
Contributor Author

@twangboy

These changes are related to async (coroutine) functionality that is not present in 3006.x.
They also seems necessary to resolve issue #68121.
Could you please take a look?

@DdangJin
Copy link
Contributor Author

@twangboy @dwoz
These changes are related to async (coroutine) functionality that is not present in 3006.x.
They also seems necessary to resolve issue #68121.
Could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DdangJin @twangboy