Skip to content

Conversation

utkarsh-pandey1-psl
Copy link

What does this PR do?

Merge the changes for fixing the root path traversal issue.

What issues does this PR fix or reference?

Fixes

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

@utkarsh-pandey1-psl utkarsh-pandey1-psl requested a review from a team as a code owner August 9, 2025 14:49
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make changes to the man pages directly. These are auto-generated.
Looks like you have some merge conflicts

@twangboy twangboy added this to the Argon v3008.0 milestone Aug 12, 2025
@twangboy twangboy added the test:full Run the full test suite label Aug 12, 2025
Comment on lines +22 to +24
# from salt.ext.six.moves import map
from salt.ext.six.moves import map
# from six.moves import map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file can be reverted to remove the commented code since there are no actual changes.

@@ -1445,7 +1445,7 @@ def generate_random_name(prefix, size=6):

.. versionadded:: 2018.3.0

prefix
efix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be prefix

@@ -101,3 +101,4 @@ tests/integration/cloud/providers/pki/minions
.bundle/
Gemfile.lock
/artifacts/
venv-salt/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a new line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants