Pin previous release of ShellCheck in CI tests #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to be the PR CI job cannot be started unless approved by project maintainers. |
s0undt3ch
approved these changes
Nov 25, 2019
|
Thanks for your review, @s0undt3ch ! Anyway, need to push blue |
|
Done. |
|
Seems to be OK, just Opensuse 15 being unstable. Need to rebase, though. |
The latest and greatest version of ShellCheck seems to have more hardened rules. This currently breaks CI tests in lint phase and shows error messages for untouched lines in a PR. It would be better to freeze the SC version and update it explicitly with fixing all new founded issues.
|
Rebased. @s0undt3ch , please take another look, this is ready to merge. Thanks! |
|
Shellcheck passed, merging. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It would be better to freeze the SC version and update it explicitly
with fixing all new founded issues.
What issues does this PR fix or reference?
The latest and greatest version of ShellCheck seems to have more
hardened rules. This currently breaks CI tests in lint phase and
shows error messages for untouched lines in a PR.
I see the fixes for the latest version are here: 7d0b06c
But it would not be added until the whole PR #1381 gonna to be merged.
In the meanwhile, the lint check for any other PRs will be broken.
@s0undt3ch, @Ch3LL, please take a look.