Fix Amazon Linux 2 Python 3 support and other clean up #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
reviewed
Dec 11, 2019
vutny
reviewed
Dec 12, 2019
added 15 commits
December 12, 2019 11:02
…talled for Py 3 tests
|
Just a heads up that you will want to remove the |
vutny
reviewed
Dec 17, 2019
vutny
reviewed
Dec 22, 2019
|
Looks good, the CI test seems to be passed. |
waynew
approved these changes
Dec 23, 2019
s0undt3ch
suggested changes
Dec 23, 2019
Akm0d
approved these changes
Dec 23, 2019
s0undt3ch
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides bootstrap support for Amazon Linux 2 Python 3 support, and other minor cleanup
Work-in-progress to utilize testing
What issues does this PR fix or reference?
#1391
Previous Behavior
Installed Python 2 Amazon Linux 2 salt-minion, when Python 3 Amazon Linux 2 salt-minion was desired
New Behavior
Installs Python 3 Amazon Linux 2 salt-minion via bootstrap with '-x python3' parameter.