Skip to content

Allow to use minor versions on Debian #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

didiermfb
Copy link

@didiermfb didiermfb commented Nov 8, 2024

What does this PR do?

Allow minor versions for Debian
Can't test on other OS

What issues does this PR fix or reference?

Related to #2027

Previous Behavior

Bootstrap used only the major version to pin package on Debian

New Behavior

Bootstrap now use the good pin version.
./bootstrap-salt.sh stable 3006.5
Result :

$ cat /etc/apt/preferences.d/salt-pin-1001
Package: salt-*
Pin: version 3006.5
Pin-Priority: 1001

./bootstrap-salt.sh stable 3006
Result :

$ cat /etc/apt/preferences.d/salt-pin-1001
Package: salt-*
Pin: version 3006.*
Pin-Priority: 1001

@dmurphy18
Copy link
Contributor

dmurphy18 commented Nov 11, 2024

@didiermfb Thanks for that, but marking as duplicate , see #2039 and #2038

But I shall take a look at your submission for doing Debian minor versions, have RedHat family and Photon OS to do also. But will get to that after getting the CI/CD build containers working.

Last release was done by hand in order to get a somewhat working script out, need the CI/CD testing working before I can make the additional changes, otherwise too much time testing.

@dmurphy18 dmurphy18 closed this Nov 11, 2024
@dmurphy18
Copy link
Contributor

@didiermfb Thanks for that, added your change and testing is good, just got to get rpm doing similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants