Skip to content

Conversation

lumenCodes
Copy link
Contributor

@lumenCodes lumenCodes commented May 1, 2025

I have updated the conf.py file by adding sphinx_sitemap to the extension. I also added the baseurl.

But the tests failed.

This will fix the issue #1

@scriptautomate-bc scriptautomate-bc self-assigned this May 1, 2025
@scriptautomate-bc
Copy link
Contributor

@lumenCodes Can you rebase your branch with the latest updates from main? I've added some updates to main that will run tests so that I can see the test results on your PR

@lumenCodes lumenCodes force-pushed the user-guide-sitemap branch from ef827b4 to 8b19dbc Compare May 2, 2025 01:50
@lumenCodes
Copy link
Contributor Author

I have rebased the branch @scriptautomate-bc

@scriptautomate-bc scriptautomate-bc marked this pull request as ready for review May 2, 2025 16:05
Copy link
Contributor

@scriptautomate-bc scriptautomate-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes being requested. After getting these changes in, make sure your next git commit is done as normal so that pre-commit can auto-apply the remaining fixes it wants to apply for the pre-commit tests to pass.

@scriptautomate-bc
Copy link
Contributor

Looks good! I'll do a follow-up PR that should resolve some other problems with the repo, which will improve the sitemap that is now getting generated.

@scriptautomate-bc scriptautomate-bc merged commit a82e7c6 into saltstack:main May 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants